Ensure that, if we're developing inside a venv, the venv python is used #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appveyor is happy but Travis is failing with an obscure core dump somewhere in py.test |
|
Perhaps the pytest issue is the one described here: pytest-dev/pytest#6492 - maybe we should try, as suggested, to pin the version to latest one without that issue |
|
Thanks, @dybber. I've merged and closed this PR for now (as I'm working on the Windows stuff). But I'll open a separate one with only that pytest change we'll see what happens. |
|
Generated #1057 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is hopefully a non-controversial PR to ensure that the Windows make.py uses Python from the running virtualenv, otherwise it won't pick up the installed packages