Skip to content

Commit

Permalink
Use rust-numpy 0.13.1 and bumpy MSRV to 1.41.1
Browse files Browse the repository at this point in the history
As a conclusion to PyO3/rust-numpy#146 the MSRV for rust-numpy was
defined as matching PyO3 and being 1.41.1. The rust-numpy 0.13.1
release handled this and relaxed it's dependency on upstream
dependencies (namely ndarray) to enable building with rust 1.41.1. Since
rust 1.41.1 is what is shipped with Debian buster it will work for
retworkx (so we don't block piwheels which relies on the debian rustc
package). This commit bumps the rust-numpy version to the latest release
and correspondingly bumps the MSRV to match at 1.41.1 which also unblocks
the use of the latest PyO3 release.
  • Loading branch information
mtreinish committed Mar 17, 2021
1 parent 19622ba commit 033dc7a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 46 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Expand Up @@ -42,7 +42,7 @@ jobs:
]
include:
# Test minimal supported Rust version
- rust: 1.39.0
- rust: 1.41.1
python-version: 3.8
platform: { os: "ubuntu-latest", python-architecture: "x64", rust-target: "x86_64-unknown-linux-gnu" }
msrv: "MSRV"
Expand Down
46 changes: 4 additions & 42 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Expand Up @@ -19,7 +19,7 @@ crate-type = ["cdylib"]
[dependencies]
petgraph = "0.5.1"
fixedbitset = "0.2.0"
numpy = "0.12.1"
numpy = "0.13.1"
rand = "0.8"
rand_pcg = "0.3"
rayon = "1.5"
Expand Down
4 changes: 2 additions & 2 deletions README.md
Expand Up @@ -5,7 +5,7 @@
[![](https://img.shields.io/github/release/Qiskit/retworkx.svg?style=popout-square)](https://github.com/Qiskit/retworkx/releases)
[![](https://img.shields.io/pypi/dm/retworkx.svg?style=popout-square)](https://pypi.org/project/retworkx/)
[![Coverage Status](https://coveralls.io/repos/github/Qiskit/retworkx/badge.svg?branch=master)](https://coveralls.io/github/Qiskit/retworkx?branch=master)
[![Minimum rustc 1.39](https://img.shields.io/badge/rustc-1.39+-blue.svg)](https://rust-lang.github.io/rfcs/2495-min-rust-version.html)
[![Minimum rustc 1.41.1](https://img.shields.io/badge/rustc-1.41.19+-blue.svg)](https://rust-lang.github.io/rfcs/2495-min-rust-version.html)

- You can see the full rendered docs at:
<https://retworkx.readthedocs.io/en/latest/index.html>
Expand Down Expand Up @@ -37,7 +37,7 @@ environment.

If there are no precompiled binaries published for your system you'll have to
build the package from source. However, to be able able to build the package
from the published source package you need to have rust >=1.39 installed (and
from the published source package you need to have rust >=1.41.1 installed (and
also [cargo](https://doc.rust-lang.org/cargo/) which is normally included with
rust) You can use [rustup](https://rustup.rs/) (a cross platform installer for
rust) to make this simpler, or rely on
Expand Down

0 comments on commit 033dc7a

Please sign in to comment.