Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New top-level #889

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

New top-level #889

wants to merge 4 commits into from

Conversation

mthom
Copy link
Owner

@mthom mthom commented Apr 7, 2021

This is a continuation of @notoria's work on a new top-level.

@triska
Copy link
Contributor

triska commented Apr 7, 2021

Thank you a lot, @notoria and @mthom! This also solves #888.

One issue I noticed is the indentation of the last line in:

?- member(X, "abc").
   X=a
;  X=b
;  X=c
;     false.

@triska
Copy link
Contributor

triska commented Apr 7, 2021

Also, please credit @notoria in the commit message!

@notoria : I hope you are OK with it? You took the initiative and did most of the work for this huge improvement!

@ghost
Copy link

ghost commented Apr 7, 2021

@triska : It's fine.

The Prolog printer is likely to introduce new issues in the future, write_term/2/write_term_to_chars/3 with quoted(true) seems to be a better alternative (more mature):

?- op(100, fy, @).
   true.
?- op(100, yf, #).
   true.
?- X = @(x#), Y = (@x)# .
   X= @x#, Y= @x# .
?-

While the expected answer: Y=(@x)#.

@tniessen
Copy link
Contributor

tniessen commented Apr 7, 2021

Also, please credit @notoria in the commit message!

Tip, you can use Co-authored-by to attribute shared work.

…' comments

Co-authored by: notoria <notoria@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants