Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix badly worded error #64

Merged
merged 1 commit into from Jan 22, 2021
Merged

Fix badly worded error #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/check/valid_owner.go
View file
Open in desktop
Expand Up @@ -243,7 +243,7 @@ func (v *ValidOwner) validateTeam(ctx context.Context, name string) *validateErr

if !teamHasWritePermission() {
return newValidateError(
"Team %q cannot review PRs on %q as neither it nor any parent team does not have write permissions.",
"Team %q cannot review PRs on %q as neither it nor any parent team has write permissions.",
team, v.orgRepoName)
}

Expand Down
4 changes: 2 additions & 2 deletions tests/integration/testdata/TestCheckFailures/owners.golden.txt
View file
Open in desktop
Expand Up @@ -22,7 +22,7 @@
[err] line 15: Team "masters" does not have permissions associated with the repository "codeowners-samples".
[err] line 15: Team "monarchy" does not have permissions associated with the repository "codeowners-samples".
[err] line 15: Team "naturals" does not have permissions associated with the repository "codeowners-samples".
[err] line 15: Team "ninjas" cannot review PRs on "codeowners-samples" as neither it nor any parent team does not have write permissions.
[err] line 15: Team "ninjas" cannot review PRs on "codeowners-samples" as neither it nor any parent team has write permissions.
[err] line 15: Team "outliers" does not have permissions associated with the repository "codeowners-samples".
[err] line 15: Team "peak-performers" does not have permissions associated with the repository "codeowners-samples".
[err] line 15: Team "power" does not have permissions associated with the repository "codeowners-samples".
Expand All @@ -35,7 +35,7 @@
[err] line 15: Team "titans" does not have permissions associated with the repository "codeowners-samples".
[err] line 15: Team "tribe" does not have permissions associated with the repository "codeowners-samples".
[err] line 15: Team "united" does not have permissions associated with the repository "codeowners-samples".
[err] line 15: Team "vikings" cannot review PRs on "codeowners-samples" as neither it nor any parent team does not have write permissions.
[err] line 15: Team "vikings" cannot review PRs on "codeowners-samples" as neither it nor any parent team has write permissions.
[err] line 15: Team "warriors" does not have permissions associated with the repository "codeowners-samples".
[err] line 15: Team "wolf-pack" does not have permissions associated with the repository "codeowners-samples".
[err] line 17: Team "not-existing-team" does not exist in organization "gh-codeowners".
Expand Down