Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.sh #184

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frankpengau
Copy link

Description

Changes proposed in this pull request:

  • adding linux/arm64 to get codeowners-validator binary

Related issue(s)

Resolves #183

@frankpengau
Copy link
Author

Just realised that the install.sh was auto-generated and should not be edited. Will change this PR.

@frankpengau
Copy link
Author

Was looking into the auto-generation of install.sh by godownloader, but then upon digging into godownloader it seems like it is archived.

@frankpengau
Copy link
Author

In the file: .goreleaser.yml , there seems to be an ignore for windows arm64:

    ignore:
      - goos: windows # due to upx error: CantPackException: can't pack new-exe
        goarch: arm64

Does it need an archives replacements for arm64 in the following:

archives:
  - replacements:
      darwin: Darwin
      linux: Linux
      windows: Windows
      386: i386
      amd64: x86_64
    format_overrides:
      - goos: windows
        format: zip

Not sure if it was intentional, due to the upx issue mentioned in: #174

@frankpengau
Copy link
Author

Correction: After testing locally, it seems to be an actual problem with the auto-generated install.sh missing the linux/arm64 platform.

@mszostok
Copy link
Owner

mszostok commented Dec 15, 2022

Hi @frankpengau!

Thanks for reporting this issue and this pull-request. I will handle that this weekend.

When it comes to the install.sh script, I think that I should figure out sth different, as this is deprecated. I used this tool, https://github.com/goreleaser/godownloader, but it's not maintained anymore.

Probably I will leave only the brew and directly binaries downloads from GitHub releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codeowners-validator install.sh crit-platform error for linux/arm64
2 participants