Support Github App authentication #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a Github App has the benefit that API calls count towards that app installation instead of a user This is useful in cases where you want to limit the number of automation users but have no such limits on Apps, since they are free
mszostok
reviewed
Apr 14, 2022
There was a problem hiding this comment.
Hi!
Thanks for your PR, I like the idea. I tested that and works well 👍
Before merging, please address the validation approach from #146 (comment). Also, please run SKIP_INSTALL=false make fix-lint-issues on your local machine and address issues as CI is failing.
The usage docs are just nice-to-have, and if you don't have time, no worries, I will add them later 👍
Co-authored-by: Mateusz Szostok <szostok.mateusz@gmail.com>
|
Thanks for the great review @mszostok! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a Github App has the benefit that API calls count towards that app installation instead of a user
This is useful in cases where you want to limit the number of automation users but have no such limits on Apps, since they are free
Let me know what you think!