Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @actions/core from 1.2.5 to 1.2.6 #74

Closed

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Sep 28, 2020

Bumps @actions/core from 1.2.5 to 1.2.6.

Changelog

Sourced from @actions/core's changelog.

1.2.6

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 28, 2020
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Sep 28, 2020

Looks like @actions/core is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Sep 28, 2020
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/actions/core-1.2.6 branch September 28, 2020 12:05
@shogo82148
Copy link

Hi, Thank you for your great works.

Could you release this update?
I got the following warning.

Warning: The add-path command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

It seems that this change is merged into the master branch 978f3c8 , but it is not released.

@eine
Copy link
Collaborator

eine commented Oct 5, 2020

@shogo82148 I believe that the warning was introduced today, but it is only shown as long as you use add-path in your workflow. This action does not use add-path, so no warning should be shown (either with 1.2.5 or with 1.2.6). Can you please provide a reference to the workflow where you are seeing the warning?

@lazka
Copy link
Member

lazka commented Oct 5, 2020

We are using core.addPath and core.exportVariable

@shogo82148
Copy link

Can you please provide a reference to the workflow where you are seeing the warning?

Here you are https://github.com/shogo82148/mecab/runs/1209533907#step:3:112

We are using core.addPath and core.exportVariable

yes, you are. but @actions/core v1.2.5 is using add-path internally.
it was fixed in v1.2.6 (ref. actions/toolkit#571), so we should update @actions/core from v1.2.5 to v1.2.6.

From https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ :

Action authors who are using the toolkit should update the @actions/core package to v1.2.6 or greater to get the updated addPath and exportVariable functions.

@eine
Copy link
Collaborator

eine commented Oct 5, 2020

@shogo82148 @lazka thanks a lot for clarifying. I have the blog article open, but I could not read it properly yet. I will tag and release ASAP.

@shogo82148
Copy link

Thanks!

@eine
Copy link
Collaborator

eine commented Oct 5, 2020

Done:

Restarting your workflows should get rid of the warnings.

@lazka
Copy link
Member

lazka commented Oct 5, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants