Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgit2: Fix pkgconfig file path relocation #20413

Merged
merged 2 commits into from Mar 23, 2024
Merged

Conversation

Biswa96
Copy link
Member

@Biswa96 Biswa96 commented Mar 23, 2024

This fixes the pkgconfig issue as discussed in #20409

@ognevny
Copy link
Collaborator

ognevny commented Mar 23, 2024

This fixes the pkgconfig issue as discussed in #20409

the issue was the thing that I forgot to put pkgconf as makedepend. btw I've found that pkg-config crate doesn't use Libs.private field: rust-lang/pkg-config-rs#152

@Biswa96
Copy link
Member Author

Biswa96 commented Mar 23, 2024

The pkgconfig in libgit2 package is also incorrect. The libdir and includedir are not properly relocated and Libs.private has CI build directory.

@Biswa96 Biswa96 merged commit bd75a07 into msys2:master Mar 23, 2024
8 checks passed
@Biswa96 Biswa96 deleted the libgit2 branch March 23, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants