Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new package] zed 0.136.2 #20056

Merged
merged 1 commit into from
May 24, 2024
Merged

[new package] zed 0.136.2 #20056

merged 1 commit into from
May 24, 2024

Conversation

ognevny
Copy link
Collaborator

@ognevny ognevny commented Feb 15, 2024

currently fails to build. see zed-industries/zed#7847

@Biswa96
Copy link
Member

Biswa96 commented Feb 15, 2024

The Windows support issue in upstream is not fixed. We should wait for proper upstream support.

@ognevny
Copy link
Collaborator Author

ognevny commented Feb 15, 2024

Not sure if it's actionable at this point: there's no support for Windows (yet) in Zed hence mingw failures are not something we're ready to consider too.

@ognevny ognevny marked this pull request as draft February 15, 2024 16:30
@ognevny
Copy link
Collaborator Author

ognevny commented Feb 15, 2024

I'll make it draft. maybe they will reconsider it in future...

@ognevny ognevny changed the title [new package] zed 0.122.2 [new package] zed 0.126.2 Mar 14, 2024
@ognevny
Copy link
Collaborator Author

ognevny commented Mar 15, 2024

I found a workaround for a new build fail in AUR. will try later

@ognevny
Copy link
Collaborator Author

ognevny commented Mar 15, 2024

I don't understand this failure

error: failed to get `tree-sitter-yaml` as a dependency of package `languages v0.1.0 (C:\_\B\src\zed-0.126.2\crates\languages)`
  Caused by:
    failed to load source for dependency `tree-sitter-yaml`
  Caused by:
    Unable to update https://github.com/zed-industries/tree-sitter-yaml?rev=f545a41f57502e1b5ddf2a6668896c1b0620f930#f545a41f
  Caused by:
    failed to update submodule `yaml-test-suite`
  Caused by:
    failed to fetch submodule `yaml-test-suite` from https://github.com/yaml/yaml-test-suite
  Caused by:
    failed to authenticate when downloading repository
    * attempted to find username/password via git's `credential.helper` support, but failed
    if the git CLI succeeds then `net.git-fetch-with-cli` may help here
    https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli
  Caused by:
    failed to acquire username/password from local configuration

@ognevny ognevny force-pushed the add-zed branch 2 times, most recently from 20ac4cf to 53b5ed5 Compare March 15, 2024 17:01
@ognevny
Copy link
Collaborator Author

ognevny commented Mar 15, 2024

successful local build 🎉. I'll download it from artifact

@ognevny ognevny marked this pull request as ready for review March 15, 2024 17:01
@ognevny
Copy link
Collaborator Author

ognevny commented Mar 15, 2024

Try adding git in makedepends.

CI still fails :(

@ognevny ognevny force-pushed the add-zed branch 2 times, most recently from 3eddc2b to e41ae05 Compare March 15, 2024 17:26
@ognevny
Copy link
Collaborator Author

ognevny commented Mar 15, 2024

Try adding git in makedepends.

CI still fails :(

https://github.com/yaml/yaml-test-suite returns 404...

edit: zed-industries/zed#9411

@mati865
Copy link
Collaborator

mati865 commented Mar 15, 2024

I guess CI is stuck on Git authentication dialog.
Overall git should be unnecessary as Cargo does use libgit2 (to be replaced with gitoxide in the future). Maybe there are awkward entries in git files or somebody force rebased the repo and that commit is no longer there.

EDIT: Ah, we've got a race condition and you have already found the reason.

@ognevny
Copy link
Collaborator Author

ognevny commented Mar 15, 2024

I guess CI is stuck on Git authentication dialog. Overall git should be unnecessary as Cargo does use libgit2 (to be replaced with gitoxide in the future). Maybe there are awkward entries in git files or somebody force rebased the repo and that commit is no longer there.

I've already found that one dependncy fetchies the git repository that doesn't exist now. when using git executable it gets stuck at it. I guess that I have this repo fetched locally in the past

upd.: back online

@ognevny
Copy link
Collaborator Author

ognevny commented Mar 16, 2024

the same issue with thin lto for non-clang environments

@ognevny ognevny force-pushed the add-zed branch 3 times, most recently from bb2233a to 7d32a12 Compare March 16, 2024 07:10
@ognevny
Copy link
Collaborator Author

ognevny commented Mar 16, 2024

non-clang envs are failing even with disabled lto. is there a way to enforce clang+lld for them?
upd.: I've found a solution

@ognevny
Copy link
Collaborator Author

ognevny commented Mar 16, 2024

❯ zed
[2024-03-16T12:48:13+03:00 ERROR fs] watch path does not exist: C:\Users\maksa\AppData\Roaming\Zed\keymap.json
[2024-03-16T12:48:13+03:00 ERROR fs] watch path does not exist: C:\Users\maksa\AppData\Roaming\Zed\settings.json
[2024-03-16T12:48:13+03:00 ERROR util] crates\settings\src\settings_file.rs:76: EOF while parsing a value at line 1 column 0
[2024-03-16T12:48:13+03:00 ERROR fs] watch path does not exist: C:\Users\maksa\AppData\Roaming\Zed\extensions\installed
[2024-03-16T12:48:13+03:00 ERROR util] crates\extension\src/extension_store.rs:266: Системе не удается найти указанный путь. (os error 3)
[2024-03-16T12:48:13+03:00 ERROR util] crates\zed\src/zed.rs:619: EOF while parsing a value at line 1 column 0
[2024-03-16T12:48:13+03:00 ERROR util] crates\zed\src/main.rs:679: Системе не удается найти указанный путь. (os error 3)
[2024-03-16T12:48:15+03:00 ERROR fs] watch path does not exist: C:\Users\maksa\AppData\Roaming\Zed\tasks.json
fish: Job 1, 'zed' terminated by signal SIGSEGV (Address boundary error)

@ognevny ognevny marked this pull request as draft March 16, 2024 09:50
@ognevny ognevny force-pushed the add-zed branch 2 times, most recently from 0503499 to 0eae89c Compare March 16, 2024 10:35
@ognevny
Copy link
Collaborator Author

ognevny commented May 10, 2024

compilation fail for UCRT64 because of GCC 14 moment. is it ok to add -Wno-incompatible-pointer-types to the C{,XX}FLAGS?

@ognevny
Copy link
Collaborator Author

ognevny commented May 10, 2024

almost all issues fixed. I'll wait until stable 0.136.x release and then push it for ucrt64

@ognevny ognevny force-pushed the add-zed branch 3 times, most recently from f55d05e to 59e4a4c Compare May 16, 2024 13:10
@ognevny ognevny changed the title [new package] zed [new package] zed 0.136.0-pre May 16, 2024
@ognevny ognevny added the new-package Pull request which adds new package(s) label May 16, 2024
@ognevny ognevny force-pushed the add-zed branch 2 times, most recently from 768c6ec to 33f01e3 Compare May 17, 2024 16:19
@ognevny ognevny changed the title [new package] zed 0.136.0-pre [new package] zed 0.136.2-pre May 17, 2024
@ognevny ognevny changed the title [new package] zed 0.136.2-pre [new package] zed 0.136.2 May 23, 2024
@ognevny ognevny marked this pull request as ready for review May 23, 2024 11:44
@ognevny ognevny force-pushed the add-zed branch 3 times, most recently from fe30381 to e62ce98 Compare May 24, 2024 11:57
@ognevny
Copy link
Collaborator Author

ognevny commented May 24, 2024

I've switched to zed as a main editor and I didn't face any bug or glitch. I've removed CLANG64 as segfault issue didn't dissappear. later I'll try to add an entry in zed docs with small guide for installing it in msys2

@ognevny ognevny merged commit 9620d9f into msys2:master May 24, 2024
8 checks passed
@ognevny ognevny deleted the add-zed branch May 24, 2024 12:54
@Kreijstal
Copy link
Contributor

for mingw64, I guess we need to compile this with mingw64 from the pkgbuild?

@ognevny
Copy link
Collaborator Author

ognevny commented May 25, 2024

for mingw64, I guess we need to compile this with mingw64 from the pkgbuild?

don't understand. you mean provide zed for mingw64? the editor (also rustc) has Windows 10 as minimum supported version. for Windows 10 and higher it's recommended to use ucrt64

@mati865
Copy link
Collaborator

mati865 commented May 25, 2024

Clang64 crash is hard to debug because it happens in this C code:
image
and obtaining full debug build is impossible because of Win32 symbols limit.

@ognevny
Copy link
Collaborator Author

ognevny commented May 25, 2024

Clang64 crash is hard to debug...

I had the crash at startup

@ognevny
Copy link
Collaborator Author

ognevny commented May 25, 2024

I had the crash at startup

backtrace
* thread #1281, stop reason = Exception 0xc0000005 encountered at address 0x7ff6f7b30000: User-mode data execution prevention (DEP) violation at location 0x7ff6f7b30000
  * frame #0: 0x00007ff6f7b30000 Zed.exe
    frame #1: 0x00007ff6fd88a82e Zed.exe`ts_wasm_store_new(engine=0x000002a116d227e0, wasm_error=0x000000ba3aafac50) at wasm_store.c:541:29
    frame #2: 0x00007ff6fb5d48c6 Zed.exe`<tree_sitter::wasm_language::WasmStore>::new at wasm_language.rs:46:25
    frame #3: 0x00007ff6fc488ae4 Zed.exe`language::with_parser::<language::syntax_map::parse_text::{closure#0}, core::result::Result<tree_sitter::Tree, anyhow::Error>>::{closure#0} at language.rs:95:29
    frame #4: 0x00007ff6f8e66298 Zed.exe`<core::option::Option<tree_sitter::Parser>>::unwrap_or_else::<language::with_parser<language::syntax_map::parse_text::{closure#0}, core::result::Result<tree_sitter::Tree, anyhow::Error>>::{closure#0}> at option.rs:978:21
    frame #5: 0x00007ff6fc488351 Zed.exe`language::with_parser::<language::syntax_map::parse_text::{closure#0}, core::result::Result<tree_sitter::Tree, anyhow::Error>> at language.rs:92:22
    frame #6: 0x00007ff6f97a9cb9 Zed.exe`language::syntax_map::parse_text at syntax_map.rs:1183:5
    frame #7: 0x00007ff6f97a7aa2 Zed.exe`<language::syntax_map::SyntaxSnapshot>::reparse_with_ranges at syntax_map.rs:661:38
    frame #8: 0x00007ff6f97a46d3 Zed.exe`<language::syntax_map::SyntaxSnapshot>::reparse at syntax_map.rs:385:9
    frame #9: 0x00007ff6f8e81a94 Zed.exe`<language::buffer::Buffer>::reparse::{closure#0} at buffer.rs:1113:17
    frame #10: 0x00007ff6fc628266 Zed.exe`<core::pin::Pin<alloc::boxed::Box<dyn core::future::future::Future<Output = language::syntax_map::SyntaxSnapshot> + core::marker::Send>> as core::future::future::Future>::poll at future.rs:123:9
    frame #11: 0x00007ff6fc4e94d6 Zed.exe`<async_task::raw::RawTask<core::pin::Pin<alloc::boxed::Box<dyn core::future::future::Future<Output = language::syntax_map::SyntaxSnapshot> + core::marker::Send>>, language::syntax_map::SyntaxSnapshot, <gpui::executor::BackgroundExecutor>::spawn_internal<language::syntax_map::SyntaxSnapshot>::{closure#0}, ()>>::run at raw.rs:557:17
    frame #12: 0x00007ff6f939e2c7 Zed.exe`<async_task::runnable::Runnable>::run at runnable.rs:781:18
    frame #13: 0x00007ff6f988999d Zed.exe`<gpui::platform::windows::dispatcher::WindowsDispatcher>::dispatch_on_threadpool::{closure#0} at dispatcher.rs:63:17
    frame #14: 0x00007ff6fe9624b5 Zed.exe`<windows::System::Threading::WorkItemHandlerBox<<gpui::platform::windows::dispatcher::WindowsDispatcher>::dispatch_on_threadpool::{closure#0}>>::Invoke at mod.rs:393:9
    frame #15: 0x00007ffd373c2ebe threadpoolwinrt.dll
    frame #16: 0x00007ffd373cab48 threadpoolwinrt.dll`DllGetClassObject + 6312
    frame #17: 0x00007ffd43ab257d kernel32.dll`BaseThreadInitThunk + 29
    frame #18: 0x00007ffd44ccaa48 ntdll.dll`RtlUserThreadStart + 40

@mati865
Copy link
Collaborator

mati865 commented May 25, 2024

I had the crash at startup

backtrace

This is what I had already posted, I couldn't debug the highlighted C code for some reason (using gdb and lldb since RustRover doesn't support C debugging).

@ognevny
Copy link
Collaborator Author

ognevny commented May 25, 2024

I see. the whole wasm thing is problematic here. it doesn't even compile with ld, lld only works here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package Pull request which adds new package(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants