Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc: Enable <stacktrace> #14559

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HazardyKnusperkeks
Copy link
Contributor

Fixes #14082.

@HazardyKnusperkeks
Copy link
Contributor Author

I'll try to get the patches into upstream.

@HazardyKnusperkeks
Copy link
Contributor Author

So what is the error here? Shouldn't MPC be a dependency already? How did you update gcc before?

@lazka
Copy link
Member

lazka commented Dec 11, 2022

hm, could be gcc version checking failing somehow. I updated mpc yesterday

edit:

In file included from conftest.c:10:
C:/msys64/ucrt64/include/mpc.h:287:35: error: unknown type name 'FILE'
  287 | __MPC_DECLSPEC void mpcr_out_str (FILE *f, mpcr_srcptr r);
      |                                   ^~~~
C:/msys64/ucrt64/include/mpc.h:27:1: note: 'FILE' is defined in header '<stdio.h>'; did you forget to '#include <stdio.h>'?
   26 | #include "mpfr.h"
   27 | 

sorry for the bad timing :/ see #14566

@HazardyKnusperkeks
Copy link
Contributor Author

So, is this good?

@lazka
Copy link
Member

lazka commented Dec 14, 2022

I don't think we have any GCC/libbacktrace developers here, so this is hard/impossible to judge.

Upstream development happens here afaik: https://github.com/ianlancetaylor/libbacktrace

@HazardyKnusperkeks
Copy link
Contributor Author

I can tell you: it works. ;)

So I have to wait to get the patches accepted upstream?

@lazka
Copy link
Member

lazka commented Dec 15, 2022

I can tell you: it works. ;)

I believe you, but I can tell you that I'm not going to spend extra time maintaining it, rebasing it, debugging it, etc ;)

So I have to wait to get the patches accepted upstream?

Yes, but we are happy to backport things, so they are available to users right away once upstream had a look.

@lazka
Copy link
Member

lazka commented Mar 10, 2023

What's the status of this?

@lazka lazka added the needinfo label Mar 10, 2023
@HazardyKnusperkeks
Copy link
Contributor Author

What's the status of this?

The review process of gcc is really not my favorite, some patches are landed, some are outstanding. I just need to motivate myself to ask again.

@ognevny
Copy link
Collaborator

ognevny commented May 3, 2024

looks like stacktrace will be enabled in gcc 14

@HazardyKnusperkeks
Copy link
Contributor Author

Yes, and most of my patches are applied, but not all of them. When the last one has landed (for gcc 15) I'll update this PR, but I'll wait for GCC 14 to be released and my vacation to be over. ;)

@lazka lazka removed the needinfo label May 3, 2024
@ognevny
Copy link
Collaborator

ognevny commented May 3, 2024

Yes, and most of my patches are applied, but not all of them. When the last one has landed (for gcc 15) I'll update this PR, but I'll wait for GCC 14 to be released and my vacation to be over. ;)

sounds good. maybe it will be nice to backport the patch after GCC 14 update is pushed

@HazardyKnusperkeks
Copy link
Contributor Author

This is the updated version, all patches except for the last one (tlhelp32 check in libstdc++) have been landed in upstream gcc and will be part of gcc 15. The last patch I'll send out later.

I've successfully tested it on UCTR64.

@HazardyKnusperkeks
Copy link
Contributor Author

The last commit was accepted upstream. Can we merge this @lazka ?

@lazka
Copy link
Member

lazka commented May 21, 2024

I'll have a look, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcc update to 12.2.0 with <stacktrace>
3 participants