fix(SetupApi): validate given request handlers #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
commented
Nov 15, 2022
| @@ -22,7 +22,7 @@ export abstract class SetupApi<EventsMap extends EventMapType> { | |||
|
|
|||
| public readonly events: LifeCycleEventEmitter<EventsMap> | |||
|
|
|||
| constructor(initialHandlers: Array<RequestHandler>) { | |||
| constructor(...initialHandlers: Array<RequestHandler>) { | |||
There was a problem hiding this comment.
Because the accepted initialHandlers were never spread, they always arrive as an Array of handlers, regardless of how they were provided to the setupServer/setupWorker function calls.
Preserving the argument spread enables the correct validation.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit de46409:
|
Released: v0.48.3 🎉This has been released in v0.48.3! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, this issue made it to
mainwithout failing tests. Caching can be so cruel sometimes.