Fix nodejs import statement in example #1202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimDaub
commented
Apr 12, 2022
TimDaub
commented
- Fixes Directory import is not supported resolving ES modules #1201
Based on conversation in mswjs#975
* chore: add "PathParams" to extract params from path strings * feat(RestHandler): extract path params from the path type * chore: move "types:ts" config to the root * fix(matchRequestUrl): strip path parameter modifiers from path names * feat(rest): remove the "ParamsType" generics Co-authored-by: Artem Zakharchenko <kettanaito@gmail.com>
…led" message (mswjs#1172) * fix: add service worker scope and worker script url to "Mocking enabled" message * chore(printStartMessage): remove context from the function Co-authored-by: Artem Zakharchenko <kettanaito@gmail.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit eb028b5:
|
|
I'm closing this because MSW doesn't have official ESM support. The import format is implied when using a certain module type. I will update the usage examples once ESM support happens. Thanks for opening this! |
4 tasks
|
If msw doesn't have ESM support ur falsely advertising your package's functionality: https://github.com/mswjs/msw#usage-example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.