fix: support "Object" as model value type #263
Conversation
There was a problem hiding this comment.
Hey, @StanleySathler! Thank you so much for proposing this. I really appreciate your feedback and ideas on the library, it's simply fantastic.
I left a few comments around this change, mainly about reusing existing utilities. Please let me know what you think about that.
kettanaito
changed the title
Object constructor to a field definition - useful for JSON columns
|
Hi! I think this feature has been asked for a while and some people are looking forward to it, if this pr makes it work it doesn't seem like a very big change. @kettanaito is it possible to inlcude this in a further release (before the all rewrite I think it is being done)? We, as well as other people, are blocked by this feature and would be so great to have it supported. Thanks! |
|
Hey @MarcLopezAvila 👋 I believe all changes Artem suggested should be pretty straightforward, which I'll take some time today to address. Then @kettanaito can decide the best way to release this. 🚀 |
|
Sounds great, thank you so much! |
StanleySathler
force-pushed
the
allow-passing-objects
branch
from
1439c73
to
c0ce51c
Compare
|
@kettanaito your feedback should be addressed now 🚀 Can you recheck? |
src/utils/isModelValueType.ts
Outdated
| @@ -1,10 +1,13 @@ | |||
| import isObjectLike from 'lodash/isObjectLike' | |||
There was a problem hiding this comment.
Nice catch - turns out we had a test set as .only too, which is also fixed now 🚀
|
Hi @kettanaito, could you check if we can merge this change pls? Thank you very much! |
See use case: #262