Fixes babel#922, extractVars instead of path removal

msn0 · Oct 26, 2018 · f8d2cbc · f8d2cbc
1 parent 6b1c350
commit f8d2cbc
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/packages/babel-plugin-minify-dead-code-elimination/__tests__/fixtures/issue-922/actual.js b/packages/babel-plugin-minify-dead-code-elimination/__tests__/fixtures/issue-922/actual.js
@@ -0,0 +1,6 @@
+function a() {
+  ++i;
+  while (false) {
+    var i = meow();
+  }
+}
diff --git a/packages/babel-plugin-minify-dead-code-elimination/__tests__/fixtures/issue-922/expected.js b/packages/babel-plugin-minify-dead-code-elimination/__tests__/fixtures/issue-922/expected.js
@@ -0,0 +1,4 @@
+function a() {
+  ++i;
+  var i;
+}
diff --git a/packages/babel-plugin-minify-dead-code-elimination/__tests__/fixtures/loops/expected.js b/packages/babel-plugin-minify-dead-code-elimination/__tests__/fixtures/loops/expected.js
@@ -1,4 +1,3 @@
-// while
 while (true) {
   bar();
 }

diff --git a/packages/babel-plugin-minify-dead-code-elimination/src/index.js b/packages/babel-plugin-minify-dead-code-elimination/src/index.js
@@ -707,7 +707,7 @@ module.exports = ({ types: t, traverse }) => {
       const test = path.get("test");
       const result = evaluate(test, { tdz: this.tdz });
       if (result.confident && test.isPure() && !result.value) {
-        path.remove();
+        path.replaceWithMultiple(extractVars(path.get("body")));
       }
     },