Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github Actions CI configuration #66

Merged
merged 1 commit into from May 6, 2021
Merged

Add Github Actions CI configuration #66

merged 1 commit into from May 6, 2021

Conversation

ms-ati
Copy link
Owner

@ms-ati ms-ati commented May 4, 2021

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2021 •
edited

Codecov Report

Merging #66 (8f3b43e) into main (bcc9d78) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           90        90           
=========================================
  Hits            90        90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcc9d78...8f3b43e. Read the comment docs.

@ms-ati ms-ati force-pushed the add-github-actions-ci branch 2 times, most recently from 7ea4b1d to 99db4c0 Compare May 4, 2021 20:51
@taichi-ishitani
Copy link
Contributor

taichi-ishitani commented May 5, 2021 •
edited

Hi @ms-ati ,

How about using Codecov GitHub Action to upload code coverage reports?
This is not a Ruby Gem so I think you can prevent the ArgumentError which is happened when uploading coverage report.

Note:
This action does not support the report format generated by Simplecov gem directly.
To use this action, I use simplecov-cobertura gem to generate XML based coverage report.
https://github.com/rggen/rggen-devtools/blob/85a13f19aae723a9e7f2cb802f1d270fb5e3a91f/lib/rggen/devtools/spec_helper.rb#L32
https://github.com/rggen/rggen/blob/45ce2c2776d2fc2810d4a02ea6f30f6056e13074/.github/workflows/ci.yml#L60

@ms-ati
Copy link
Owner Author

ms-ati commented May 6, 2021

@taichi-ishitani thank you for suggesting switching to the CodeCov Github Action!

So, I have the current configuration working now by excluding JRuby and TruffleRuby temporarily from CodeCov.

What do you think about the following plan:

  1. Merge this initial Github Actions configuration
  2. Remove the Travis CI configuration
  3. Convert to using CodeCov github action (PR welcome!)

Thoughts?

@ms-ati ms-ati force-pushed the add-github-actions-ci branch 2 times, most recently from 499f300 to f4ffb17 Compare May 6, 2021 15:21
@ms-ati
Add Github Actions CI configuration
5455d69 
Based on: https://github.com/ruby/setup-ruby

Re: #60

Some notes on the initial Github Actions config:

  1. Set min ruby version to 2.5 in order to support JRuby,
     which as of 9.2.17.0 has a RUBY_VERSION of 2.5.

  2. For CodeCov exclude JRuby and TruffleRuby, to avoid
     errors sending the results in Github Actions on those
     jobs rather than debugging them further.

  3. Plan is to next remove Travis CI, and then to convert
     the CodeCov config to use the Github Action for CodeCov
     (thanks @taichi-ishitani for this suggestion!)
@ms-ati ms-ati merged commit 46d4f3f into main May 6, 2021
@ms-ati ms-ati deleted the add-github-actions-ci branch May 6, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ms-ati @codecov-commenter @taichi-ishitani