Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from Travis CI to Github Actions (blocked by Ruby < 2.1 support) #60

Closed
2 tasks done
ms-ati opened this issue Jan 4, 2021 · 4 comments
Closed
2 tasks done
Labels
CI Continuous Integration and Testing configurations

Comments

@ms-ati
Copy link
Owner

ms-ati commented Jan 4, 2021

With experience of both, I've found maintenance of CI in Github Actions quite a bit easier than in Travis CI.

Therefore, when the day arrives that we support only Rubies supported in Github Actions, I'd like to plan to transition.

Checklist

  • Add Github Actions CI configuration, in parallel with current Travis CI
  • (blocked on Ruby versions supported) Remove configuration for Travis CI
@ms-ati
Copy link
Owner Author

ms-ati commented Jan 13, 2021

See #58.

If no significant requests for support of Docile on EOL (< 2.5) Ruby versions by Feb 1, 2021, the plan is to drop all support for EOL versions. At that point, the move from Travis CI to Github Actions would become unblocked.

@ms-ati ms-ati added the CI Continuous Integration and Testing configurations label Jan 13, 2021
@colszowka
Copy link

I believe since Ruby 2.1 has been out of maintenance for quite some time at this point (even 2.4 has been dead for a year) it should be fine to just drop support. Also, GitHub have deprecated their own setup ruby action in favor of https://github.com/ruby/setup-ruby#supported-versions which actually still supports 2.1.9 if you still want to run CI against it, but honestly I think it's in the best interest of any library users to just drop support for ruby versions that are not receiving security updates any more and force them to update anyway

@ms-ati
Copy link
Owner Author

ms-ati commented Mar 31, 2021

@colszowka agreed! There's been no other response here, so I am planning to drop support for < 2.5, and move CI to Github Actions.

@ms-ati
Copy link
Owner Author

ms-ati commented May 4, 2021

UPDATE: Support for all EOL Rubies (which now means < 2.6) dropped in #65

ms-ati added a commit that referenced this issue May 6, 2021
Based on: https://github.com/ruby/setup-ruby

Re: #60

Some notes on the initial Github Actions config:

  1. Set min ruby version to 2.5 in order to support JRuby,
     which as of 9.2.17.0 has a RUBY_VERSION of 2.5.

  2. For CodeCov exclude JRuby and TruffleRuby, to avoid
     errors sending the results in Github Actions on those
     jobs rather than debugging them further.

  3. Plan is to next remove Travis CI, and then to convert
     the CodeCov config to use the Github Action for CodeCov
     (thanks @taichi-ishitani for this suggestion!)
ms-ati added a commit that referenced this issue May 6, 2021
Based on: https://github.com/ruby/setup-ruby

Re: #60

Some notes on the initial Github Actions config:

  1. Set min ruby version to 2.5 in order to support JRuby,
     which as of 9.2.17.0 has a RUBY_VERSION of 2.5.

  2. For CodeCov exclude JRuby and TruffleRuby, to avoid
     errors sending the results in Github Actions on those
     jobs rather than debugging them further.

  3. Plan is to next remove Travis CI, and then to convert
     the CodeCov config to use the Github Action for CodeCov
     (thanks @taichi-ishitani for this suggestion!)
ms-ati added a commit that referenced this issue May 6, 2021
Based on: https://github.com/ruby/setup-ruby

Re: #60

Some notes on the initial Github Actions config:

  1. Set min ruby version to 2.5 in order to support JRuby,
     which as of 9.2.17.0 has a RUBY_VERSION of 2.5.

  2. For CodeCov exclude JRuby and TruffleRuby, to avoid
     errors sending the results in Github Actions on those
     jobs rather than debugging them further.

  3. Plan is to next remove Travis CI, and then to convert
     the CodeCov config to use the Github Action for CodeCov
     (thanks @taichi-ishitani for this suggestion!)
ms-ati added a commit that referenced this issue May 6, 2021
Re: #60

Good bye to Travis CI! You were very appreciated.

But today, supporting only Github Actions for CI will enable
some additional goals, as well as speeding up builds.
@ms-ati ms-ati mentioned this issue May 6, 2021
@ms-ati ms-ati closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration and Testing configurations
Projects
None yet
Development

No branches or pull requests

2 participants