Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing babel #161

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: removing babel #161

wants to merge 4 commits into from

Conversation

mrsteele
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #161 into master will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   98.59%   98.43%   -0.16%     
==========================================
  Files           1        1              
  Lines          71       64       -7     
==========================================
- Hits           70       63       -7     
  Misses          1        1              
Impacted Files Coverage Δ
src/index.js 98.43% <100.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7270d...fe56474. Read the comment docs.

@emanualjade
Copy link

Hi @mrsteele
Is removing babel still on the roadmap? Or upgrading to babel 7?

@mrsteele
Copy link
Owner Author

mrsteele commented Aug 3, 2019

It is! You got thoughts or feedback?!?

@emanualjade
Copy link

emanualjade commented Aug 3, 2019

I don't have any super useful feedback right up front.

My own codebase has a few packages using babel 6 that cause conflicts with babel v7. Part of which lead me to your PR. So was pretty excited to see this PR in progress and wanted to get a feel for where you were with this one. To see if it's close or if there are specific things that prevented it from being merged.

I'd need a bit of an upgrade on babel to be able to provide useful technical help. Of course not out of the question.

@mrsteele
Copy link
Owner Author

mrsteele commented Aug 3, 2019

This PR is essentially done. I was nervous to push the button because of the popularity of this, but also the worry of the impact of how much it would be supported on older versions of node

@emanualjade
Copy link

emanualjade commented Aug 3, 2019

I hear you on that. It does have quite a few users.
On the other hand since this PR was crafted, babel 7 has gained quite a bit in popularity. Would a major version change of dotenv-webpack be enough to make forward movement with the PR?

Still supporting current users on the previous versions

hmmm. If really wanting to support older versions of node going forward maybe even then a different PR that just does an upgrade to Babel 7 and save this one for later when the time is right.

@mrsteele
Copy link
Owner Author

@emanualjade Just wanted to mention this plugin is now using babel 7. Hopefully that solves some of the problems you were facing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants