Release v2.1.6

mrrhak · Dec 4, 2023 · e7a34c8 · e7a34c8
1 parent cbcf22e
commit e7a34c8
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/.github/workflows/format-analyze.yml → .github/workflows/format-analyze-test.yml b/.github/workflows/format-analyze.yml → .github/workflows/format-analyze-test.yml
@@ -21,3 +21,6 @@ jobs:
 
       - name: Analyze
         run: dart analyze --fatal-infos --fatal-warnings .
+
+      - name: Test
+        run: dart test
diff --git a/lib/src/android.dart b/lib/src/android.dart
@@ -501,7 +501,8 @@ int _minSdk() {
     minSdkValue = _getLineValueNumber(flutterLines, flutterLineKey);
   }
 
-  return int.tryParse(minSdkValue ?? '0') ?? 0;
+  if (minSdkValue != null) return int.tryParse(minSdkValue) ?? 0;
+  return ANDROID_DEFAULT_MIN_SDK;
 }
 
 /// Retrieves the flutter sdk path

diff --git a/lib/utils/constants.dart b/lib/utils/constants.dart
@@ -21,6 +21,10 @@ const String END_MESSAGE = '''\n
 const String FLUTTER_SDK_GRADLE_FILE =
     '/packages/flutter_tools/gradle/flutter.gradle';
 
+/// Default min_sdk value for android
+/// https://github.com/flutter/flutter/blob/master/packages/flutter_tools/gradle/flutter.gradle#L35-L37
+const int ANDROID_DEFAULT_MIN_SDK = 21;
+
 /// Android local properties file location
 const String ANDROID_LOCAL_PROPERTIES = 'android/local.properties';
 

diff --git a/test/main_test.dart b/test/main_test.dart
@@ -10,7 +10,7 @@ void main() {
     // Read yaml config file
     final file = File('pubspec.yaml');
     final content = file.readAsStringSync();
-    final yaml = loadYaml(content) as Map<String, dynamic>;
+    final yaml = loadYaml(content) as Map;
 
     expect(packageVersion, yaml['version'].toString(),
         reason: 'Version is not correct');
@@ -20,7 +20,7 @@ void main() {
     // Read yaml config file
     final file = File('pubspec.yaml');
     final content = file.readAsStringSync();
-    final yaml = loadYaml(content) as Map<String, dynamic>;
+    final yaml = loadYaml(content) as Map;
 
     final length = yaml['description'].toString().length;
     expect(length, greaterThan(60),