feat: Added option to consider ringer mode in Android #2811
+19
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey - thank you for your contribution, this is much appreciated. I always prioritize PRs over issues to discuss such things. In this case, I think the prop can be a bit confusing. The naming, especially combined with the description, isn't very obvious. I think that the current behaviour is perfectly fine - it is exactly how it is on iOS. When the phone is on silent, we don't want any sound. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When using the takePhoto function in Android, ringerMode is not applied by default, but is applied when a value is received as an option
If isAppliedRingerMode option is set to true in takePhoto function,
When ringerMode is RINGER_MODE_NORMAL, the shutterSound option is applied.
When the ringer mode is RINGER_MODE_SILENT or RINGER MODE VIBRATE, the shutter Sound option is ignored.
Changes
Tested on
Related issues