Fix/fix third party ndk headers not found with REACT_NATIVE_DOWNLOADS_DIR setted #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ebuilding will be failed
changhuali
changed the title
|
Doesn't this run quite often then now? I think those steps are invoked very often, not just once... |
|
Can you confirm that the files are not unnecessarily being unzipped multiple times by addiing logs there? |
This is the build log after |
|
Hi, should this pr be merged or closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
After setting REACT_NATIVE_DOWNLOADS_DIR environment variable, rebuilding will be failed with follow reasons:
This is just because we forget to unzip the cached resources and copy them into the thirdPartyNdkDir dir
Changes
Remove the dependOn guard in prepareThirdPartyNdkHeaders task so that the prepare tasks could be done.
Tested on
Related issues