perf: Use the truly native pixel format on iOS if available #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mrousavy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
According to the
videoSettingsdocumentation, the truly native format is used whenvideoSettingsis set to[:]- so this adds a path where this can happen (hdr is false, buffer compression is not enabled or available, and pixelFormat isnative)Not sure if this makes any difference, I think I already pick the format that is truly native for that format.
Before merging this PR, let's confirm that the pixelFormat is now different when calling
CMSampleBufferGetFormatDescription(frame.buffer)in a FP Plugin.Changes
Tested on
Related issues