multi-process mode #639
Open
multi-process mode #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MolnarRolandSV
approved these changes
Feb 29, 2024
|
Hey, thanks so much for your PR, this is really exciting. I am a bit swamped with work right now, so it might take a few days before I can review this, hope you understand! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
AppGroupis present in bundle. Needed for this. Now if an application hasAppGroupset for some reason and does not want to save the data in the appGroup location, it will be able to use the default mmkv location by setting mode:single-process.modeconfiguration.I'm not sure about moving the
RCTUnsafeExecuteOnMainQueueSync()function to thecreateFromHostFunction()function. I've tested it on iOS and it seems to work without problems. I attach the video:Screen.Recording.2024-02-27.at.15.43.47.mov