Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App group enhancement introduced a breaking change (2.10.0) #627

Open
JP250552 opened this issue Feb 7, 2024 · 2 comments
Open

App group enhancement introduced a breaking change (2.10.0) #627

JP250552 opened this issue Feb 7, 2024 · 2 comments

Comments

@JP250552
Copy link

JP250552 commented Feb 7, 2024

The change introducing app groups moved the storage location when the app groups property is set which is a breaking change - https://github.com/mrousavy/react-native-mmkv/pull/402/files#diff-b667beab6bbb6d80aab761c6781a9a7fea5812e5814d98666080a2ec6edb38dfR46

Upgrading to 2.10.0 causes our users to lose stored data since we had an app group previously defined for other reasons.

It would probably be good to revert and release that change as v3 and also provide a way to override that storage location for backwards comparability.

@mrousavy
Copy link
Owner

mrousavy commented Feb 8, 2024

Oh, whoops. Hmm I don't think reverting that change makes sense as that was more than a year ago and most people are already on that version by then, meaning they'll lose any data unless they upgrade to v3.

I think you could easily migrate by moving the mmkv file from the normal directory to the appgroup directory.

@JP250552
Copy link
Author

JP250552 commented Feb 8, 2024

That's a fair point. Would you be opposed to us adding a property to allow using the default location?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants