Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support keys with '.' characters in them #194

Merged
merged 3 commits into from
May 28, 2021
Merged

Support keys with '.' characters in them #194

merged 3 commits into from
May 28, 2021

Conversation

mrodrig
Copy link
Owner

@mrodrig mrodrig commented May 28, 2021

Background Information

I have...

  • added at least one test to verify the failure condition is fixed.
  • verified the tests are passing.

Through modifications to `doc-path` and `deeks` dependency underlying
code, I've worked to add support for the keys with nested dots in the
JSON key path and conversion back to CSV. This was achieved through the
`deeks` module's new `escapeNestedDots` option which will now be set to
`true`. Additionally, support for this escaping was added to `doc-path`
so that the correct values are retrieved and can also be correctly set
for csv2json. This commit adds the option specification for the `deeks`
module and the updated versions of the dependency modules in
package.json.

Fixes #184
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.266% when pulling aff1aee on fix-184 into 8778fb2 on 3.14.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.266% when pulling aff1aee on fix-184 into 8778fb2 on 3.14.0.

@mrodrig mrodrig merged commit bd1fd28 into 3.14.0 May 28, 2021
mrodrig added a commit that referenced this pull request May 28, 2021
* chore(release): 3.14.0

* Support keys with '.' characters in them (#194)

* Add support for keys with nested dots.

Through modifications to `doc-path` and `deeks` dependency underlying
code, I've worked to add support for the keys with nested dots in the
JSON key path and conversion back to CSV. This was achieved through the
`deeks` module's new `escapeNestedDots` option which will now be set to
`true`. Additionally, support for this escaping was added to `doc-path`
so that the correct values are retrieved and can also be correctly set
for csv2json. This commit adds the option specification for the `deeks`
module and the updated versions of the dependency modules in
package.json.

Fixes #184
@mrodrig mrodrig deleted the fix-184 branch April 10, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants