Validate field titles against Object.keys list

.travis.yml

@@ -3,10 +3,10 @@ env:
     - CC_TEST_REPORTER_ID=90382d7264499c819f742709fe7cb4b2d2a49cc90fd98a9c8414426ac4860e62
 language: node_js
 node_js:
+  - "16"
   - "15"
   - "14"
   - "12"
-  - "10"
 sudo: false
 before_script:
   - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter

lib/json2csv.js

@@ -143,9 +143,12 @@ const Json2Csv = function(options) {
      * @returns {*}
      */
     function generateCsvHeader(params) {
+        // #185 - generate a keys list to avoid finding native Map() methods
+        let fieldTitleMapKeys = Object.keys(options.fieldTitleMap);
+
         params.header = params.headerFields
             .map(function(field) {
-                const headerKey = options.fieldTitleMap[field] ? options.fieldTitleMap[field] : field;
+                const headerKey = fieldTitleMapKeys.includes(field) ? options.fieldTitleMap[field] : field;
                 return wrapFieldValueIfNecessary(headerKey);
             })
             .join(options.delimiter.field);

test/config/testCsvFilesList.js

@@ -39,7 +39,8 @@ const fs = require('fs'),
         {key: 'firstColumnWrapCRLF', file: '../data/csv/firstColumnWrapCRLF.csv'},
         {key: 'emptyLastFieldValue', file: '../data/csv/emptyLastFieldValue.csv'},
         {key: 'emptyLastFieldValueNoEol', file: '../data/csv/emptyLastFieldValueNoEol.csv'},
-        {key: 'lastCharFieldDelimiter', file: '../data/csv/lastCharFieldDelimiter.csv'}
+        {key: 'lastCharFieldDelimiter', file: '../data/csv/lastCharFieldDelimiter.csv'},
+        {key: 'nativeMapMethod', file: '../data/csv/nativeMapMethod.csv'}
     ];
 
 function readCsvFile(filePath) {

test/config/testJsonFilesList.js

@@ -29,5 +29,6 @@ module.exports = {
     invalidParsedValues: require('../data/json/invalidParsedValues'),
     firstColumnWrapCRLF: require('../data/json/firstColumnWrapCRLF.json'),
     emptyLastFieldValue: require('../data/json/emptyLastFieldValue.json'),
-    emptyLastFieldValueNoEol: require('../data/json/emptyLastFieldValueNoEol.json')
+    emptyLastFieldValueNoEol: require('../data/json/emptyLastFieldValueNoEol.json'),
+    nativeMapMethod: require('../data/json/nativeMapMethod.json')
 };

test/data/csv/nativeMapMethod.csv

@@ -0,0 +1,2 @@
+set,otherfieldname
+test,test2

test/data/json/nativeMapMethod.json

@@ -0,0 +1,6 @@
+[
+    {
+        "set": "test",
+        "otherfieldname": "test2"
+    }
+]

test/json2csv.js

@@ -137,6 +137,14 @@ function runTests(jsonTestData, csvTestData) {
                     done();
                 });
             });
+
+            it('should properly handle headers with the same name as native Map methods', (done) => {
+                converter.json2csv(jsonTestData.nativeMapMethod, (err, csv) => {
+                    if (err) done(err);
+                    csv.should.equal(csvTestData.nativeMapMethod);
+                    done();
+                });
+            });
         });
 
         describe('Error Handling', () => {