Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose lookup tables #117

Merged
merged 1 commit into from Apr 7, 2024
Merged

expose lookup tables #117

merged 1 commit into from Apr 7, 2024

Conversation

BKSalman
Copy link
Contributor

resolves #112

any comments?

@akhilles
Copy link
Collaborator

akhilles commented Apr 2, 2024

LGTM. The new Implementation API was just merged (#115). Do you mind rebasing? Sorry for the churn.

@BKSalman
Copy link
Contributor Author

BKSalman commented Apr 2, 2024

Will do, np

@BKSalman
Copy link
Contributor Author

BKSalman commented Apr 2, 2024

@akhilles should I make it like this?

    pub const fn table(&self) -> <Table<1> as Implementation>::Data<u8> {
        self.data
    }

akhilles
akhilles requested changes Apr 2, 2024
View reviewed changes
src/crc128/bytewise.rs Outdated Show resolved Hide resolved
@BKSalman
Copy link
Contributor Author

BKSalman commented Apr 4, 2024

I will be off for holidays, and won't be able to commit for a couple of days, I will try to tho since it's just a small change

@akhilles akhilles merged commit 2dab409 into mrhooray:master Apr 7, 2024
6 checks passed
@BKSalman
Copy link
Contributor Author

BKSalman commented Apr 7, 2024

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhilles akhilles akhilles requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expose tables in API
2 participants
@BKSalman @akhilles