Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/mingw: remove cache #11728

Merged
merged 2 commits into from Jun 8, 2023
Merged

ci/mingw: remove cache #11728

merged 2 commits into from Jun 8, 2023

Conversation

kasper93
Copy link
Contributor

No description provided.

To avoid building against stale version of dependencies. In particular
libplacebo is moving target and as we can see the build has been broken
few times recently, so let the CI validate it for us.

The time to build everything is under 30 minutes, which is acceptable in
my opinion, not much longer than macos build.
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS isn't exactly a good example of a non-slow build but whatever

@sfan5
Copy link
Member

sfan5 commented May 30, 2023

Alternatively maybe we could incorporate a date into the cache key so that everything is automatically rebuilt every week. If you just want to quickly check something waiting 30m for mingw results can be quite annoying.

@kasper93
Copy link
Contributor Author

kasper93 commented May 30, 2023

Alternatively maybe we could incorporate a date into the cache key so that everything is automatically rebuilt every week. If you just want to quickly check something waiting 30m for mingw results can be quite annoying.

I would like to have CI validate current status and flag PR before getting merged. So building current master, especially of libplacebo, but also ffmpeg is nice.

Proper solution would probably to compute cache hash based on dependencies version/git hash that are currently built. So we can skip rebuilt if we are up to date and only do clone. But I'm not sure how to do it nicely. I have some idea, but it would require a lot of changes to make it work.

If you just want to quickly check something waiting 30m for mingw results can be quite annoying.

Agreed. fwiw, for quickly check other build should finish sooner.

For me more annoying are sporadic failures... Either the macos build fails or msys2 due to msys2/MINGW-packages#11864 It is really like playing bowling, you need to have a little luck to get them all ;p

@sfan5
Copy link
Member

sfan5 commented May 30, 2023

Proper solution would probably to compute cache hash based on dependencies version/git hash that are currently built.

It's easy to do the conditional caching for everything: https://github.com/actions/cache#creating-a-cache-key
Could adjust the script to always rebuild ffmpeg and libplacebo then.

For me more annoying are sporadic failures... Either the macos build fails or msys2 due to msys2/MINGW-packages#11864 It is really like playing bowling, you need to have a little luck to get them all ;p

Agreed.

@Traneptora Traneptora merged commit 6ff131a into mpv-player:master Jun 8, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants