Fix incorrect button rounding #4862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.btn-group uses :first-child and :last-child to determine which buttons should have rounded corners and which ones should have square corners. The "Quiet" button had a square left corner, because the first child was a CSRF hidden field tag. Keeping only .btn elements inside the .btn-group means that the 1 or 2 buttons are rounded as expected. When there's no "Quiet" button, the "Stop" button has 4 round corners. When both buttons are present, the corners between the buttons are square. Fixes sidekiq#4858
|
Sharp detective work! |
|
Thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.btn-group uses :first-child and :last-child to determine which buttons should have rounded corners and which ones should have square corners. The "Quiet" button had a square left corner, because the first child was a CSRF hidden field tag.
Keeping only .btn elements inside the .btn-group means that the 1 or 2 buttons are rounded as expected. When there's no "Quiet" button, the "Stop" button has 4 round corners. When both buttons are present, the corners between the buttons are square.
Fixes #4858
I traced this problem to this diff. f0ddebc#diff-d68d7f0b05d0be529c7d2493225a3cd8e5358f0c6327b7dfc8ead5f2927a1ba1L50-L59
The buttons now look like this:
When both buttons are present
When only Stop is present
