Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mperham/connection_pool#113 expose pool from Wrapper #114

Merged
merged 3 commits into from Mar 1, 2019

Conversation

ook
Copy link
Contributor

@ook ook commented Feb 28, 2019

Expose pool from ConnectionPool::Wrapper

See #113

@mperham
Copy link
Owner

mperham commented Feb 28, 2019

I'd like the method to be a little more explicit, maybe wrapped_pool?

@mperham
Copy link
Owner

mperham commented Feb 28, 2019

And can you add an access in the test suite to exercise it?

@ook
Copy link
Contributor Author

ook commented Mar 1, 2019

Hi @mperham thank you for your interest. I changed the method name as requested. What do you mean by "adding an access in the test suite"? I added a test to check the method correctly expose the ConnectionPool, but maybe it's not sufficient?

@mperham mperham merged commit 99b81aa into mperham:master Mar 1, 2019
@mperham
Copy link
Owner

mperham commented Mar 1, 2019

Thank you!

@aliou
Copy link

aliou commented May 17, 2019

Hello @mperham, do you know when this will be available in a new version of the gem ? Thanks! (also Hi @ook!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants