Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSI build script #597

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add SSI build script #597

wants to merge 3 commits into from

Conversation

james58899
Copy link
Contributor

@james58899 james58899 commented Jun 27, 2018

使用 ssi 將所有shtml檔案處理成html並輸出至out資料夾

輸出位置可從 build.js 的 outDir 變數設定

排除inc資料夾內的shtml生成,因為那些是要引入其他shtml用的,並不能獨立生成
排除node_modules資料夾,因為他並不應該是網站的一部份

將部分檔案內include的目標改成shtml,這樣才能成功處理

@irvin
Copy link
Member

irvin commented Jun 27, 2018

不能直接把 include .html 的部分改成 .shtml,因為要保留原本機器上的相容性,得要想想怎麼繞過去。
又或者先切不同的 branch 來處理。

最後 tools/mozlcdb/index.shtml 的修改另外切一個 PR 吧。

另外 commit log、PR 跟新檔案的說明,以及 readme 都盡量詳細點寫一下吧。

@othree
Copy link
Contributor

othree commented Jun 27, 2018

shtml 檔案都建個副檔名 html 的 link file (?)

@irvin
Copy link
Member

irvin commented Jun 27, 2018

@othree 感覺會讓原本的 build script 炸掉
https://github.com/moztw/base/blob/master/autoupdate/update.sh

@irvin
Copy link
Member

irvin commented Jun 28, 2018

#596 merge 之後 rebase
每個檔案加一下註解,readme 多一個段落說明做什麼跟怎麼用吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants