Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust to 1.63, MSR to 1.61.0 #1314

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Update Rust to 1.63, MSR to 1.61.0 #1314

merged 2 commits into from
Aug 30, 2022

Conversation

mhammond
Copy link
Member

As per our Rust version policy

Requires some clippy fixes. Also fixed some clippy complaints in nightly.

@mhammond mhammond requested a review from a team as a code owner August 24, 2022 01:00
@mhammond mhammond requested review from tarikeshaq and removed request for a team August 24, 2022 01:00
@mhammond mhammond marked this pull request as draft August 24, 2022 01:35
@mhammond
Copy link
Member Author

mhammond commented Aug 24, 2022 •
edited

A new version of trybuild seems to be at least one of the problems here - apparently not - I thought I ran all the tests locally but apparently not :(

@mhammond mhammond force-pushed the update-rust branch 3 times, most recently from 33428cb to e6816cd Compare August 24, 2022 03:21
@mhammond
Copy link
Member Author

This works, but only with the min tests running with -j 1 to avoid OOM. I've no idea why, and it seems worse to bump the machine to xlarge, so I'm opening this for review, but sadly it's not quite a rubber stamp.

@mhammond mhammond marked this pull request as ready for review August 24, 2022 03:54
@mhammond
Copy link
Member Author

@badboy pointed me at rust-lang/rust#97549, so I think my approach seems sane.

@mhammond
Update Rust to 1.63, MSR to 1.61.0
8e00615 
As per our [Rust version policy](https://github.com/mozilla/uniffi-rs/blob/main/docs/policies/rust-versions.md)

Requires some clippy fixes. Also fixed some clippy complaints in nightly.
@mhammond mhammond merged commit e913610 into mozilla:main Aug 30, 2022
@mhammond mhammond deleted the update-rust branch August 30, 2022 04:33
@badboy badboy mentioned this pull request Sep 5, 2022
Closed
@tarikeshaq tarikeshaq mentioned this pull request Sep 12, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarikeshaq tarikeshaq tarikeshaq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mhammond @tarikeshaq