Pin to clap 3.1 and modernize some aspects of clap usage. #1273
Conversation
|
For other projects I've just set the version specification to There's lots of discussion about these deprecation warnings at clap-rs/clap#3822. |
|
Thanks for that and yeah, I agree that's probably the best course of action. I might try and keep the non-breaking changes in my PR though |
mhammond
changed the title
There was a problem hiding this comment.
👍
especially for staying on 3.1
Going to 3.2 will most likely cause pain getting it into m-c because of other things there depending on clap and thus also requiring the update. I'm not keen on doing that anytime soon really (I only just last week did land a 3.1 update to some other part)
| @@ -19,7 +19,7 @@ anyhow = "1" | |||
| askama = { version = "0.11", default-features = false, features = ["config"] } | |||
| cargo_metadata = "0.14" | |||
| camino = "1.0.8" | |||
| clap = { version = "3.1", features = ["cargo", "std", "derive"] } | |||
| clap = { version = "~3.1", features = ["cargo", "std", "derive"] } | |||
There was a problem hiding this comment.
This can now be reverted as deprecations are now off by default, see clap-rs/clap#3830 for details. When you do start working through the deprecations as part of upgrading to 4.0, we've also improved the warnings for derive users. See clap-rs/clap#3832 for examples.
Fixes #1272, [edit to remove references to bumping the clap version]