-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MySQL integration and dedicated code #7814
Conversation
There are still a few places where mysql is mentioned in treeherder code, some changes might require a bit of investigation and development and should probably be applied as follow-ups:
In the accessing_data.md and administration.md documentation files, the instructions to use "Treeherder's read-only MySQL replica" should also be reworked to apply to a Postgres replica instead. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7814 +/- ##
==========================================
- Coverage 77.12% 77.04% -0.09%
==========================================
Files 545 545
Lines 26989 26920 -69
Branches 3385 3393 +8
==========================================
- Hits 20815 20740 -75
- Misses 6007 6013 +6
Partials 167 167 ☔ View full report in Codecov by Sentry. |
This PR has been rebased on latest changes from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me, but I'd like @Archaeopteryx input on the remaining few Mysql mentions (especially around .distinct()
that should be usable now)
Sorry for not landing this yet. I want to get the local development with remote PostgreSQL instance working which fails because the dockerflow package tries to apply migrations. I'll try to ifdef the package for dev environments. |
517b97c
to
b267767
Compare
b267767
to
0cdf373
Compare
Thank you for the patch, the remaining mentions of MySQL in code comments as reported above will be addressed in follow-up commits, e.g. together with changes to use a remote GCP PostgreSQL instance locally. |
Refs #7811