Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MySQL integration and dedicated code #7814

Merged
merged 5 commits into from
May 30, 2024

Conversation

EvaBardou
Copy link
Collaborator

Refs #7811

@EvaBardou EvaBardou requested a review from a team as a code owner September 20, 2023 17:03
@EvaBardou EvaBardou marked this pull request as draft September 20, 2023 17:03
@EvaBardou EvaBardou mentioned this pull request Sep 20, 2023
@EvaBardou
Copy link
Collaborator Author

There are still a few places where mysql is mentioned in treeherder code, some changes might require a bit of investigation and development and should probably be applied as follow-ups:


In the accessing_data.md and administration.md documentation files, the instructions to use "Treeherder's read-only MySQL replica" should also be reworked to apply to a Postgres replica instead.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.04%. Comparing base (704390f) to head (517b97c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7814      +/-   ##
==========================================
- Coverage   77.12%   77.04%   -0.09%     
==========================================
  Files         545      545              
  Lines       26989    26920      -69     
  Branches     3385     3393       +8     
==========================================
- Hits        20815    20740      -75     
- Misses       6007     6013       +6     
  Partials      167      167              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvaBardou EvaBardou marked this pull request as ready for review September 21, 2023 12:50
@EvaBardou
Copy link
Collaborator Author

This PR has been rebased on latest changes from master, this comment about MySQL's remaining mentions is still true and up to date.

Copy link
Collaborator

@La0 La0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me, but I'd like @Archaeopteryx input on the remaining few Mysql mentions (especially around .distinct() that should be usable now)

@Archaeopteryx
Copy link
Collaborator

Sorry for not landing this yet. I want to get the local development with remote PostgreSQL instance working which fails because the dockerflow package tries to apply migrations. I'll try to ifdef the package for dev environments.

@Archaeopteryx Archaeopteryx merged commit 494ca3c into mozilla:master May 30, 2024
3 of 4 checks passed
@Archaeopteryx
Copy link
Collaborator

Thank you for the patch, the remaining mentions of MySQL in code comments as reported above will be addressed in follow-up commits, e.g. together with changes to use a remote GCP PostgreSQL instance locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants