Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add % percentage indicator to standard deviation #7772

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sumairq
Copy link
Contributor

@sumairq sumairq commented Aug 14, 2023

This PR adds a % percentage indicator to the standard deviation in compare view.

It is a solution for https://bugzilla.mozilla.org/show_bug.cgi?id=1831319.
image

@gmierz gmierz requested a review from esanuandra August 15, 2023 15:46
@gmierz
Copy link
Collaborator

gmierz commented Aug 15, 2023

@sumairq one other thing we'll need to do is determine the number of standard deviations used in the percentage.

@sumairq
Copy link
Contributor Author

sumairq commented Aug 23, 2023

@sumairq one other thing we'll need to do is determine the number of standard deviations used in the percentage.

The number of Standard deviations is located inside the tooltip before the percentage.
image

@gmierz
Copy link
Collaborator

gmierz commented Sep 28, 2023

@sumairq one other thing we'll need to do is determine the number of standard deviations used in the percentage.

The number of Standard deviations is located inside the tooltip before the percentage. image

This gives the absolute size of the standard deviation, that said, I took a look and I'm unable to find us making any changes to the stddev before we display it so the %, and the number are equivalent to 1 standard deviation:

displayNumber(stddevpct),

I don't know where we can mention this though, any ideas @sumairq?

@gmierz
Copy link
Collaborator

gmierz commented Oct 4, 2023

Thinking about this further, we could do XX% for 1 standard deviation instead of XX% standard deviation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants