Bug 1840394 - Use signature_id instead of signature_hash for graphs l…

…ink. (#7876) * Bug 1840394 - Use signature_id instead of signature_hash for CompareView graphs link. * Resolve same issue in the CompareSubtestsView.
mozilla · Nov 17, 2023 · e641af6 · e641af6
1 parent be24884
commit e641af6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/ui/perfherder/compare/CompareSubtestsView.jsx b/ui/perfherder/compare/CompareSubtestsView.jsx
@@ -96,8 +96,8 @@ class CompareSubtestsView extends React.PureComponent {
       });
     }
     const signatureHash = !oldResults
-      ? newResults.signature_hash
-      : oldResults.signature_hash;
+      ? newResults.signature_id
+      : oldResults.signature_id;
 
     links = createGraphsLinks(
       this.props.validated,
@@ -139,9 +139,13 @@ class CompareSubtestsView extends React.PureComponent {
       cmap.name = testName;
       if (oldResults !== undefined) {
         cmap.suite = oldResults.suite;
+        cmap.baseColumnMeasurementUnit = oldResults.measurement_unit;
+        cmap.app = oldResults.application;
       }
       if (newResults !== undefined) {
         cmap.suite = newResults.suite;
+        cmap.newColumnMeasurementUnit = newResults.measurement_unit;
+        cmap.app = newResults.application;
       }
 
       if (

diff --git a/ui/perfherder/compare/CompareView.jsx b/ui/perfherder/compare/CompareView.jsx
@@ -120,8 +120,8 @@ class CompareView extends React.PureComponent {
       });
     }
     const signatureHash = !oldResults
-      ? newResults.signature_hash
-      : oldResults.signature_hash;
+      ? newResults.signature_id
+      : oldResults.signature_id;
     links = createGraphsLinks(
       this.props.validated,
       links,