Skip to content

Commit

Permalink
Bug 1848885 - Add mention of ./mach try perf --alert to comment 0 (#7890
Browse files Browse the repository at this point in the history
)

This PR strengthens the message of the alert comment to let them know the mach try perf command.
  • Loading branch information
junngo committed Dec 12, 2023
1 parent 85d0ef3 commit 465da39
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 0 deletions.
18 changes: 18 additions & 0 deletions treeherder/perf/fixtures/performance_bug_templates.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
You can run these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
For more information on performance sheriffing please see our [FAQ](https://wiki.mozilla.org/TestEngineering/Performance/FAQ).
- model: perf.PerformanceBugTemplate
pk: 2
Expand All @@ -29,6 +31,8 @@
Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests. Please follow our [guide to handling regression bugs](https://wiki.mozilla.org/TestEngineering/Performance/Handling_regression_bugs) and **let us know your plans within 3 business days, or the patch(es) may be backed out** in accordance with our [regression policy](https://www.mozilla.org/en-US/about/governance/policies/regressions/).
You can run these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
For more information on performance sheriffing please see our [FAQ](https://wiki.mozilla.org/TestEngineering/Performance/FAQ).
- model: perf.PerformanceBugTemplate
pk: 4
Expand All @@ -46,6 +50,8 @@
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
You can run these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
For more information on performance sheriffing please see our [FAQ](https://wiki.mozilla.org/TestEngineering/Performance/FAQ).
- model: perf.PerformanceBugTemplate
pk: 5
Expand All @@ -63,6 +69,8 @@
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
You can run these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
For more information on performance sheriffing please see our [FAQ](https://wiki.mozilla.org/TestEngineering/Performance/FAQ).
- model: perf.PerformanceBugTemplate
pk: 6
Expand All @@ -80,6 +88,8 @@
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
You can run these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
For more information on performance sheriffing please see our [FAQ](https://wiki.mozilla.org/TestEngineering/Performance/FAQ).
- model: perf.PerformanceBugTemplate
pk: 7
Expand All @@ -97,6 +107,8 @@
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
You can run these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
For more information on performance sheriffing please see our [FAQ](https://wiki.mozilla.org/TestEngineering/Performance/FAQ).
- model: perf.PerformanceBugTemplate
pk: 8
Expand All @@ -114,6 +126,8 @@
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
You can run these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
For more information on performance sheriffing please see our [FAQ](https://wiki.mozilla.org/TestEngineering/Performance/FAQ).
- model: perf.PerformanceBugTemplate
pk: 9
Expand All @@ -131,6 +145,8 @@
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
You can run these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
For more information on performance sheriffing please see our [FAQ](https://wiki.mozilla.org/TestEngineering/Performance/FAQ).
- model: perf.PerformanceBugTemplate
pk: 10
Expand All @@ -148,4 +164,6 @@
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
You can run these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
For more information on performance sheriffing please see our [FAQ](https://wiki.mozilla.org/TestEngineering/Performance/FAQ).
1 change: 1 addition & 0 deletions ui/perfherder/alerts/StatusDropdown.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ export default class StatusDropdown extends React.Component {
revisionHref: repoModel.getPushLogHref(alertSummary.revision),
alertHref: `${window.location.origin}/perfherder/alerts?id=${alertSummary.id}`,
alertSummary: textualSummary.markdown,
alertSummaryId: alertSummary.id,
};

templateSettings.interpolate = /{{([\s\S]+?)}}/g;
Expand Down

0 comments on commit 465da39

Please sign in to comment.