force LF as newLine character #919
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotlessApply would otherwise convert all newLine characters to CRLF on windows
|
This is of course a fine idea but I am worried since we have files in the test directories (and some test262 files) with CRLF line endings. What happens on Windows when one checks those out with this flag set? And do all the tests run on Windows? I don't have Windows set up to test this, unless it's using Ubuntu on Windows which I assume still uses LF. |
|
@gbrail I'll get back to you on that one |
|
Would it make sense to only set |
|
Definitely -- that's lower risk I think.
…On Fri, Jun 4, 2021 at 12:23 AM tonygermano ***@***.***> wrote:
Would it make sense to only set eol=lf for *.java files?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#919 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD7I26DG7HELGMTTOZ5FNLTRB5QNANCNFSM454SVWJA>
.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spotlessApply would otherwise convert all newLine characters to CRLF on
windows
Closes: #918