New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullPointerException fix when calling JS methods exposed as JavaProxys - JSR223 #1456

Open

EduFrazao wants to merge 1 commit into mozilla:master from EduFrazao:getInterface_NPEFix

+3 −0

EduFrazao commented Mar 13, 2024

With a JavaScript like that

    function run() {
         print('Some string');
    }

If I try to invoke it from a JavaProxy using this code, I got a NullPointerException

   final ScriptEngine engine = engineManager.getEngineByName("rhino");
   engine.eval(myScript);
   Invocable inv = (Invocable) engine;
   Runnable runnable = inv.getInterface(Runnable.class);
   runnable.run();


          NPE fix when a non-argument JavaScript method is collected

d4c21bc

 and exposed as a JavaProxy calling "getInterface"
 of RhinoScriptEngine

Collaborator

rbri commented Apr 27, 2024

@EduFrazao can you please add an unit test to your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment