Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementation of Reflect & Proxy support #1431

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

implementation of Reflect & Proxy support #1431

wants to merge 31 commits into from

Conversation

rbri
Copy link
Collaborator

@rbri rbri commented Dec 27, 2023

sorry made a mistake during the update/rebase of #1332

This is the current version

@rbri
first implementation of NativeReflect
32c76f9
@rbri
fix broken backward compatibility (use the same approach as for all t…
2af111f 
…he other symbol based methods)
@rbri
fix typos
6f2e843
@rbri
working on proxy support (wip)
a14836c
@rbri
apply implemented
a778d4b
@rbri
built-ins/Proxy 152/306 (49.67%)
11e7ea1 
milestone I reached
@rbri
built-ins/Proxy 134/306 (43.79%)
ccb2bda
@rbri
convert to lambda
18f010a
@rbri
built-ins/Proxy 120/306 (39.22%)
bc02187
@rbri
built-ins/Proxy 93/306 (30.39%)
42f8dfe
@rbri
getOwnPropertyDescriptor [built-ins/Proxy 88/306 (28.76%) / built-ins…
166f81c 
…/Reflect 20/139 (14.39%)]
@rbri
more detailed get trap handling
8e0cab8
@rbri
NativeProxy has to support revoking from a trap
7c16e1b 
SymbolKeys are shallowEq to symbols
isArray has to take care of proxies
@rbri
implement more details for defineProperty
bbd5e5d 
fix missing return for put traps
@rbri
construct now supports newTarget
c1ff1fd
@rbri
current status of the impl
1d8d99d
@rbri
spotless
9b2993f
@rbri
remove leftover from lambda migration
db5443e
@rbri
defineOwnProperty() now return a boolean - THIS BREAKS backward compa…
f2caa7c 
…tibility
@rbri
preventExtensions has to return a boolean (incompatible change)
89fa899
@rbri
one more get fix
cd353f1
@rbri
next minor step
f12c678
@rbri
fix handling of primitive values in Reflect.apply (see HtmlUnit/htmlu…
4f4944a 
…nit#641)
@rbri
fix rebase
976af2c
@rbri
fix rebase
7288d22
@rbri
some more test are fixed with the latest rebase
8518a8f
@rbri
some fixes based on HtmlUnit#9
70bfa44
@rbri
spotless
144e93c
@rbri
Copy link
Collaborator Author

rbri commented Dec 27, 2023

current status of the impl

built-ins/Array 188/2670 (7.04%)              built-ins/Array 174/2670 (6.52%)
built-ins/Function 186/505 (36.83%)           built-ins/Function 185/505 (36.63%)
built-ins/JSON 36/140 (25.71%)                built-ins/JSON 28/140 (20.0%)
built-ins/Object 122/3150 (3.87%)             built-ins/Object 102/3150 (3.24%)
built-ins/Promise 404/599 (67.45%)            built-ins/Promise 403/599 (67.28%)
                                              built-ins/Proxy 74/306 (24.18%)
                                              built-ins/Reflect 13/139 (9.35%)
language/expressions/typeof 1/16 (6.25%)      language/expressions/typeof 0/16 (0.0%)
language/statements/for-of 471/725 (64.97%)   language/statements/for-of 470/725 (64.83%)

@rbri rbri mentioned this pull request Mar 27, 2024
Open
@p-bakker p-bakker linked an issue Apr 9, 2024 that may be closed by this pull request
Support ES2015 Proxies & Reflect API #268
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ES2015 Proxies & Reflect API
1 participant
@rbri