-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make rhino-engine an osgi bundle #1278
base: master
Are you sure you want to change the base?
Conversation
LGTM, but no osgi expert by far It seems to bring @carlosame any thoughts, since you're the one to last make changes in this area (in #873)? |
"Bundle-SymbolicName": "org.mozilla.rhino.engine", | ||
"Bundle-Version": project.version.replaceAll("-.*", ""), | ||
"Export-Package": "org.mozilla.javascript.engine", | ||
"Import-Package": "javax.script,org.mozilla.javascript" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not declare an Import-Package
, and instead leave the default (automatic) behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an OSGi import.(has nothing to do with the Automatic-Module-Name) If you do not declare it the bundle will not work/ throw an ClassNotFoundExcaption because bundle does not declare that is needs it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's weird. I do not use OSGi myself, however from https://bnd.bndtools.org/heads/import_package.html:
The
Import-Package
header lists the packages that are required by the contained packages. The default for this header is*
, resulting in importing all referred packages. This header therefore rarely has to be specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep. bnd is a tool that calculates die imports. if you say to bnd do *
then it will habe as result in the manifest:
Import-Package javax.script,org.mozilla.javascript
but since yopu do not use a tool loke bnd you have to write it by yourown
@juergen-albert (OSGi Working Group Steering Committee)
could you please review this from the OSGi point of view?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What @stbischof wrote is correct. bnd is a build tool, that can calculate the Imports for you with proper Version ranges. The same goes for the Export Packages. OSGi requires all the packages to be named separately and can not interpret the *.
bnd even has a dedicated gradle plugin that can automatically calculate a Manifest for your, not only putting in proper OSGi Headers, but can also automatically handle things in respect to Java Module System.
I'm not that firm with gradle, but you can find an example of the gradle plugin usage here: https://github.com/osgi/osgi-test/tree/main/examples/osgi-test-example-gradle
I commented on this in a few issues, like #1092. Essentially, Quoting from one of my comments in the aforementioned issue (#1092 (comment)):
|
Hi we also should add the Capability.
also a missing import in core
next Steps? |
solves:#1277