Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zh_CN messages resource #1240

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ylk2534246654
Copy link

Add zh_CN messages resource

@rbri
Copy link
Collaborator

rbri commented Jun 25, 2022

Thanks for the contribution.
I think we have some unit tests for the error message translation. Maybe you can enhance some tests.

@gbrail
Copy link
Collaborator

gbrail commented Jul 30, 2022

This is awesome work and it'll be great to have. Before merge, do you think that we could have:

  1. A basic unit test that verifies that, when the locale is set, messages at least come out from the right catalog. "MessageProviderLanguageTest.java" does this -- we just need to update it for Chinese.
  2. I'd like one other Chinese speaker to verify that these messages are indeed reasonable Chinese translations and are OK to add in the source code.

I can do #1 if there is someone in the community who can do the second part!

@p-bakker
Copy link
Collaborator

p-bakker commented Nov 7, 2023

@gbrail I've pasted the content of the modified file with the Chinese translations into Google Translate and the translations seem to hold up just fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants