Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat-table/babel/core-js release steps to RELEASE-STEPS.md. #1164

Closed
wants to merge 5 commits into from

Conversation

phulin
Copy link
Contributor

@phulin phulin commented Jan 25, 2022

As requested, this PR just adds steps for updating compat-table and babel to the release documentation. I've already filed a PR against compat-table and will deal with babel when that gets merged:

compat-table/compat-table#1786

Closes #661

@zloirock
Copy link
Contributor

It should be added also to core-js, see zloirock/core-js#942

@phulin
Copy link
Contributor Author

phulin commented Jan 25, 2022

Of course, thank you!

@phulin phulin changed the title Add compat-table and babel release steps to RELEASE-STEPS.md. Add compat-table/babel/core-js release steps to RELEASE-STEPS.md. Jan 25, 2022
@phulin
Copy link
Contributor Author

phulin commented Jan 25, 2022

@zloirock Added instructions, although they're honestly a little dense. If you have an obvious better solution, I'd be curious to hear it.

RELEASE-STEPS.md Outdated
* Copy the most recent rhino JAR into the directory as `rhino.jar`.
* Edit `tests/compat/tests.js` by replacing all instances of `GLOBAL` with
`global`.
* Edit `packages/core-js-compat/src/data.js` to be a CommonJS module rather
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use core-js-compat/data.json when you built core-js.

RELEASE-STEPS.md Outdated

* Update `COMPAT_TABLE_COMMIT` in `packages/babel-compat-data/scripts/download-compat-table.sh`
to correspond to the merge commit in `compat-table`.
* Run `npm run build`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests might need to be updated. I suggest replacing npm run build with make bootstrap, and then add an OVERWRITE=true yarn jest step to update the fixtures if necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks - something is wrong here which I figure is better to discuss in the babel PR.

@gbrail
Copy link
Collaborator

gbrail commented Jan 27, 2022

This looks fine with me, but I see some discussion about the specific steps -- can you resolve the comments above or let me know if you think it's good to go anyway? Thanks!

@phulin
Copy link
Contributor Author

phulin commented Jan 27, 2022

I think this is good to go now. There's some further work that could be done to make regenerating the core-js info easier, but that can easily happen the next time we need to do this based on these instructions.

@p-bakker
Copy link
Collaborator

Would it make sense to at least write in a comment here exactly what improvements could be made and then add a little note in RELEASE-STEPS.MD referring to that comment, as I think for most of the Rhino contributors here things might not be as clear as they are for you?

@p-bakker
Copy link
Collaborator

p-bakker commented Feb 1, 2022

@phulin Any change you can resolve the comments on this PR and have a look at my previous comment, to see if it makes sense to do that or not?

@tonygermano
Copy link
Contributor

@phulin Do you know what would be required to have Rhino taken off of the "Obsolete platform" list?

@p-bakker
Copy link
Collaborator

p-bakker commented Feb 1, 2022

FYI: compat-table/compat-table#1687

So maybe the answer to your question is: convincing @ljharb it is not obsolete :-)

@ljharb
Copy link

ljharb commented Feb 1, 2022

@p-bakker to be fair, when i made that comment there was no indication that there’d ever be a new and/or updated version of rhino.

if you’re releasing new versions that implement most of the living JS standard, then obv the new versions wouldn’t be obsolete.

@p-bakker
Copy link
Collaborator

p-bakker commented Feb 1, 2022

@ljharb point taken :-)

We do have a bit of a backlog of things to implement to get back up to standard (which is being worked on, albeit slowly), but the project is far from dead for a usage perspective

So, fair to say that is we put out a couple of releases that close the gap to the latest EcmaScript version, we should ring the bell to get Rhino taken off of the 'obsolete platform' list?

@ljharb
Copy link

ljharb commented Feb 1, 2022

That sounds like a fine plan to me.

(usage doesn’t matter all that much, IE 9 still gets plenty of usage, but it’s still obsolete)

@phulin
Copy link
Contributor Author

phulin commented Feb 1, 2022

@phulin Any change you can resolve the comments on this PR and have a look at my previous comment, to see if it makes sense to do that or not?

Yep, I have been meaning to do this and just haven't gotten around to it. It's a good point, it's all in my head right now and should get written down. Thanks.

@p-bakker
Copy link
Collaborator

@phulin dont mean to push, but any chance you could wrap this one up so it can be merged? Will shortly want to build on top of it

@phulin
Copy link
Contributor Author

phulin commented Feb 15, 2022

@phulin dont mean to push, but any chance you could wrap this one up so it can be merged? Will shortly want to build on top of it

Added some inline notes on how one could contribute back to core-js to make it easier.

@phulin
Copy link
Contributor Author

phulin commented Feb 15, 2022

Not sure what is going on w/ the CI...

@p-bakker
Copy link
Collaborator

Tnx, looks good to me. @rbri, @gbrail can you give this a quick look over and merge?

Not sure what is going on w/ the CI...

First-time committer, CI had to be launched manually

@gbrail
Copy link
Collaborator

gbrail commented Feb 17, 2022

There was a small problem with duplicating the last few lines of RELEASE-STEPS so I squashed and merged this manually. Thanks for updating this!

@gbrail gbrail closed this Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Is there a recommended version of babel preset env to use when transpiling down ES2020 features?
7 participants