Update the Babel plugin to remove empty class constructors #18060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
force-pushed
the
babel-plugin-class
branch
from
a8e9e3e
to
e347999
Compare
f724ae9 changed the build script to use Babel, so this commit updates the file names accordingly
nicolo-ribaudo
force-pushed
the
babel-plugin-class
branch
from
e347999
to
5cdc965
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This only happens when it's safe to do so. The exceptions are: - when the class extends another subclass: removing the constructor would remove the error about the missing super() call - when there are default parameters, that could have side effects - when there are destructured prameters, that could have side effects
nicolo-ribaudo
force-pushed
the
babel-plugin-class
branch
from
5cdc965
to
46626ac
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/35e361ea1c727c3/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c73cb7fa3ebb1b6/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/c73cb7fa3ebb1b6/output.txt Total script time: 27.63 mins
Image differences available at: http://54.241.84.105:8877/c73cb7fa3ebb1b6/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/35e361ea1c727c3/output.txt Total script time: 42.58 mins
Image differences available at: http://54.193.163.58:8877/35e361ea1c727c3/reftest-analyzer.html#web=eq.log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18057