Don't stroke when the current path isn't in the current clip box

[calixteman]

No description provided.

[calixteman]

/botio test

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fea28a26e181415/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a9596b60b2e72cc/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/fea28a26e181415/output.txt

Total script time: 25.19 mins

• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 31
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/fea28a26e181415/reftest-analyzer.html#web=eq.log

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/a9596b60b2e72cc/output.txt

Total script time: 39.23 mins

• Unit tests: FAILED
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 10

Image differences available at: http://54.193.163.58:8877/a9596b60b2e72cc/reftest-analyzer.html#web=eq.log

[calixteman]

/botio test

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b9873fe39f3c800/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/91721a1403753d4/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/b9873fe39f3c800/output.txt

Total script time: 25.35 mins

• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 24
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/b9873fe39f3c800/reftest-analyzer.html#web=eq.log

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/91721a1403753d4/output.txt

Total script time: 41.87 mins

• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 9

Image differences available at: http://54.193.163.58:8877/91721a1403753d4/reftest-analyzer.html#web=eq.log

[Snuffleupagus]

While I don't know what this patch tries to fix, however looking at the code changes I'm not that surprised by the test failures.

Note that as-is this won't update all state as expected for the consumePath === true case, and it seems to me that this situation is similar to the one for optional content; i.e. you'd instead want to change

pdf.js/src/display/canvas.js

Line 1772 in 6bb6ce6

if (this.contentVisible) {

into

 if (this.contentVisible && this.current.isPathInClipBox()) {

[calixteman]

I just filed this issue: #17779
I don't know if it's the right fix but at least it helps to really decrease the time spent to render from few minutes to few seconds.
But maybe those skipped lines are supposed to be rendered to draw the borders...