Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages and translations #13715

Merged
merged 4 commits into from Jul 11, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

No description provided.

@Snuffleupagus
Copy link
Collaborator Author

/botio lint

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/4edc2af0ca61f3e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/393148b37fed2fe/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/4edc2af0ca61f3e/output.txt

Total script time: 2.53 mins

  • Lint: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/393148b37fed2fe/output.txt

Total script time: 3.94 mins

  • Lint: Passed

@timvandermeij
Copy link
Contributor

I read about a possible regression in Puppeteer 10.1.0, see puppeteer/puppeteer#7414, so we'll have to see if it affects us as well.

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/3f7733805f9a810/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://3.101.106.178:8877/1b218e97462ed03/output.txt

@timvandermeij
Copy link
Contributor

While it does look like that PR is for functionality in Puppeteer that we don't use, namely connecting to a remote browser instance, it can't hurt to make sure :-)

@Snuffleupagus
Copy link
Collaborator Author

I read about a possible regression in Puppeteer 10.1.0, see puppeteer/puppeteer#7414, so we'll have to see if it affects us as well.

While it does look like that PR is for functionality in Puppeteer that we don't use, namely connecting to a remote browser instance, it can't hurt to make sure :-)

All tests pass locally with this patch, so I believe that we should be good here. (I was just waiting on tests to finish locally, before triggering them here :-)

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/3f7733805f9a810/output.txt

Total script time: 31.99 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 11
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/3f7733805f9a810/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/1b218e97462ed03/output.txt

Total script time: 36.42 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 7
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/1b218e97462ed03/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit 94b60b3 into mozilla:master Jul 11, 2021
@timvandermeij
Copy link
Contributor

Thanks!

@Snuffleupagus Snuffleupagus deleted the update-packages branch July 11, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants