fix: html encode backslashes if used with escape filter or autoescape #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backslashes should be html encoded when present in expressions that are passed to the escape filter (including when this happens automatically with autoescape)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1437 +/- ##
=======================================
Coverage 89.65% 89.65%
=======================================
Files 22 22
Lines 3046 3046
=======================================
Hits 2731 2731
Misses 315 315
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
valtlai
added a commit
to valtlai/nunjucks-deno
that referenced
this pull request
Apr 13, 2023
…mozilla/nunjucks#1437) Backslashes should be html encoded when present in expressions that are passed to the escape filter (including when this happens automatically with autoescape) --- Ported from mozilla/nunjucks@ec16d21 Co-Authored-By: Frankie Dintino <fdintino@gmail.com>
valtlai
added a commit
to valtlai/nunjucks-deno
that referenced
this pull request
Apr 13, 2023
…mozilla/nunjucks#1437) Backslashes should be html encoded when present in expressions that are passed to the escape filter (including when this happens automatically with autoescape) --- Ported from mozilla/nunjucks@ec16d21 Co-Authored-By: Frankie Dintino <fdintino@gmail.com>
4 tasks
otc-zuul bot
pushed a commit
to opentelekomcloud-infra/backstage
that referenced
this pull request
May 9, 2023
Bump nunjucks from 3.2.3 to 3.2.4 Bumps nunjucks from 3.2.3 to 3.2.4. Release notes Sourced from nunjucks's releases. v3.2.4 What's Changed fix: html encode backslashes if used with escape filter or autoescape by @fdintino in mozilla/nunjucks#1437. Fixes CVE-2023-2142 ([bugzilla #1825980](https://bugzilla.mozilla.org/show_bug.cgi?id=1825980)) Full Changelog: mozilla/nunjucks@v3.2.3...v3.2.4 Changelog Sourced from nunjucks's changelog. 3.2.4 (Apr 13 2023) HTML encode backslashes when expressions are passed through the escape filter (including when this is done automatically with autoescape). Merge of #1437. Commits 86a77f4 Release v3.2.4 ec16d21 fix: html encode backslashes if used with escape filter or autoescape (#1437) See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the Security Alerts page. Reviewed-by: Artem Goncharov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backslashes should be html encoded when present in expressions that are passed to the escape filter (including when this happens automatically with autoescape)