Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chokidar bump #1254

Merged
merged 1 commit into from Mar 15, 2020
Merged

Chokidar bump #1254

merged 1 commit into from Mar 15, 2020

Conversation

eklingen
Copy link
Contributor

@eklingen eklingen commented Nov 23, 2019

Summary

Proposed change:

Update optional dependency chokidar from ^2.0.0 to ^3.3.0.

This fixes the warning users get when installing:

warning nunjucks > chokidar > fsevents@1.2.9: One of your dependencies needs to upgrade to fsevents v2: 1) Proper nodejs v10+ support 2) No more fetching binaries from AWS, smaller package size

There are also performance improvements, and fsevents no longer has to be built at install. For more information, see: https://paulmillr.com/posts/chokidar-3-save-32tb-of-traffic/

The API of v3 is the same as v2, except that dotfiles are no longer ignored by default. I don't think this is relevant for nunjucks. The minimum node version is bumped from v6 to v8, but i'm not sure if that matters considering v6 is no longer in maintenance.

Checklist

I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.

@fdintino
Copy link
Collaborator

I can't make sense of the appveyor failures, but that's not worth holding up the merge of this. Thank you!

@fdintino fdintino merged commit 17691da into mozilla:master Mar 15, 2020
@antonsamper
Copy link

@fdintino when is the next planned release?

@fdintino
Copy link
Collaborator

fdintino commented Mar 16, 2020

Today. Going to spend a short amount of time trying to verify that there aren't actually runtime errors on windows (the appveyor failures) before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants