Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix engine dependency version for Node versions > 11.1.0 #1169

Merged
merged 1 commit into from Dec 13, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
@@ -1,6 +1,17 @@
Changelog
=========

* Fix engine dependency version for Node versions > 11.1.0;
now there is only a minimum Node dependency and not a maximum dependency;
the engine dependency is now a blacklist rather than a whitelist;
it indicates Node versions that are known NOT to work, and unknown future
versions are accepted by default rather than rejected by default.
This fixes a systematic problem where Nunjucks and all of its downstream
dependencies break every time a new Node version is released, despite the
Node update being backwards compatible, thus forcing a new Nunjucks
release such as 3.1.4 until the goalpost is soon moved again.
Fixes [#1168](https://github.com/mozilla/nunjucks/issues/1168).

3.1.4 (Nov 9 2018)
------------------

Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -63,7 +63,7 @@
"babel-register": "@babel/register"
},
"engines": {
"node": ">= 6.9.0 <= 11.1.0"
"node": ">= 6.9.0"
},
"scripts": {
"build:transpile": "babel nunjucks --out-dir .",
Expand Down