Merge pull request #1126 from TheDancingCode/issue-126

Escape unicode newlines when compiling
mozilla · Sep 4, 2018 · 39bb716 · 39bb716
2 parents 9a0ce36 + 4d4dc40
commit 39bb716
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,8 @@
 Changelog
 =========
 
+* Fix "Unexpected token" error for U+2028 unicode newline. Fixes [#126](https://github.com/mozilla/nunjucks/issues/126) and [#736](https://github.com/mozilla/nunjucks/issues/736)
+
 3.1.3 (May 19 2018)
 -------------------
 

diff --git a/nunjucks/src/compiler.js b/nunjucks/src/compiler.js
@@ -278,6 +278,7 @@ class Compiler extends Obj {
       val = val.replace(/\n/g, '\\n');
       val = val.replace(/\r/g, '\\r');
       val = val.replace(/\t/g, '\\t');
+      val = val.replace(/\u2028/g, '\\u2028');
       this._emit(`"${val}"`);
     } else if (node.value === null) {
       this._emit('null');

diff --git a/tests/compiler.js b/tests/compiler.js
@@ -55,6 +55,11 @@
       finish(done);
     });
 
+    it('should escape Unicode line seperators', function(done) {
+      equal('\u2028', '\u2028');
+      finish(done);
+    });
+
     it('should compile references', function(done) {
       equal('{{ foo.bar }}',
         {