Bug 1686039 - Migrate from travis to github actions #834
Conversation
wlach
force-pushed
the
github-actions
branch
2 times, most recently
from
ded19fa
to
76aa3c3
Compare
|
@KwanEsq I don't know if you're interested in skimming this over? Still missing are release uploads, which I figured I would do in a followup. Also, Mac builds don't work on MacOS 11, I will probably skip publishing a new version for Mac until the underlying issues are fixed (see pyinstaller/pyinstaller#5107, which has links to a number of the problems). |
There was a problem hiding this comment.
Great work! 💯 Sorry I wasn't able to help out. I took a glance at the actions docs after you filed the bug, but confess I found myself a little lost and intimidated. Haven't had much experience with build tools apart from sr.ht.
Looks good to my limited knowledge, only a few comments and questions.
A lot of the black formatting changes seem to be purely because of some function calls/dicts/tuples having trailing commas, often in disagreement to their siblings. Not really worth going to the effort of fixing now though.
Hah, can't comment directly on empty files: I take it from the commit message the pytest.ini is needed for a test to run? The docs mention
pytest.ini files take precedence over other files, even when empty.
but don't seem to elaborate on what effect an empty file actually has (apart from determining the rootdir ?)
Also, Mac builds don't work on MacOS 11, I will probably skip publishing a new version for Mac until the underlying issues are fixed (see pyinstaller/pyinstaller#5107, which has links to a number of the problems).
Would it not be worth still doing a macOS build and just including a "not for 11" disclaimer? Or is take-up that good in macOS land that there aren't that many non-11 users left?
Those pyinstaller issues look hairy though, good old system library changes again. At least the CLI version still works on 11.
I take it Windows builds aren't also switched to Actions because it's not needed as appveyor is still working/not limited unlike Travis?
No description provided.